codeant-ai-for-open-source[bot] commented on code in PR #43809: URL: https://github.com/apache/superset/pull/43809#discussion_r3919965363
########## superset/sql/dialects/starrocks.py: ########## @@ -0,0 +1,139 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +StarRocks dialect for Superset, extending sqlglot's built-in StarRocks dialect. + +sqlglot's MySQL parser (which StarRocks' parser inherits from) resolves the +schema in ``SHOW TABLES/DATABASES FROM|IN <schema>`` with ``_parse_id_var()``, +which only ever consumes a single identifier. StarRocks additionally supports a +catalog-qualified schema reference for its external catalogs, e.g. +``SHOW TABLES IN catalog.schema``, which then fails to parse: sqlglot consumes +the first identifier as the schema and leaves ``.schema`` dangling, which is +rejected as an unexpected token. +""" + +from __future__ import annotations + +from sqlglot import exp +from sqlglot.dialects.starrocks import StarRocks as _StarRocks +from sqlglot.parsers.starrocks import StarRocksParser as _StarRocksParser Review Comment: **Suggestion:** sqlglot 30.x does not provide `sqlglot.parsers.starrocks`, so importing `superset.sql.dialects` raises `ModuleNotFoundError` and breaks all SQL parsing at startup. [import error] **Assessment:** ๐ด `Critical` ยท ๐ `Occurrence: Often` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4b1addc599a2411e991bca6eb176ac81&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4b1addc599a2411e991bca6eb176ac81&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/sql/dialects/starrocks.py **Line:** 34:34 **Comment:** *Import Error: sqlglot 30.x does not provide `sqlglot.parsers.starrocks`, so importing `superset.sql.dialects` raises `ModuleNotFoundError` and breaks all SQL parsing at startup. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43809&comment_hash=1981350b98ba5d36089d63eebeb8c5ab6ce761df3fea98e38ee4f75248bdecdc&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43809&comment_hash=1981350b98ba5d36089d63eebeb8c5ab6ce761df3fea98e38ee4f75248bdecdc&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
