hainenber commented on code in PR #43712:
URL: https://github.com/apache/superset/pull/43712#discussion_r3925570162
##########
docs/developer_docs/components/ui/select.mdx:
##########
@@ -283,7 +282,6 @@ function OneLineDemo() {
| Prop | Type | Default | Description |
|------|------|---------|-------------|
| `mode` | `string` | `"single"` | Whether to allow selection of a single
option or multiple. |
-| `placeholder` | `string` | `"Select ..."` | Placeholder text when no option
is selected. |
| `showSearch` | `boolean` | `true` | Whether to show a search input for
filtering. |
Review Comment:
Fixed in HEAD commit
##########
docs/docs/index.mdx:
##########
@@ -159,7 +159,6 @@ single source of truth. The README.md retains its own
static copy
<a href="/user-docs/databases/supported/apache-pinot" title="Apache
Pinot"><img src="/img/databases/apache-pinot.svg" alt="Apache Pinot" width="76"
height="40" /></a>
<a href="/user-docs/databases/supported/apache-solr" title="Apache
Solr"><img src="/img/databases/apache-solr.png" alt="Apache Solr" width="79"
height="40" /></a>
<a href="/user-docs/databases/supported/apache-spark-sql" title="Apache
Spark SQL"><img src="/img/databases/apache-spark.png" alt="Apache Spark SQL"
width="75" height="40" /></a>
- <a href="/user-docs/databases/supported/ascend" title="Ascend"><img
src="/img/databases/ascend.webp" alt="Ascend" width="117" height="40" /></a>
<a href="/user-docs/databases/supported/aurora-mysql-data-api" title="Aurora
MySQL (Data API)"><img src="/img/databases/mysql.png" alt="Aurora MySQL (Data
API)" width="77" height="40" /></a>
Review Comment:
Fixed in commit
https://github.com/apache/superset/pull/43712/commits/317e80f6a80ad1c7de158b636b8d3eb63622cfcd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
