villebro commented on PR #43843: URL: https://github.com/apache/superset/pull/43843#issuecomment-5534455287
For the record, this matches the pre-migration (GAQ) precedent, which was also static/resolve-once — reinforcing that the fixed-channel design is correct and not a regression: - Flask: `GLOBAL_ASYNC_QUERIES_REDIS_STREAM_PREFIX = "async-events-"`, read once in `AsyncQueryManager.init_app` into `self._stream_prefix` (a plain `str`). - websocket: `redisStreamPrefix` (default `async-events-`, `REDIS_STREAM_PREFIX` env), read once at startup; stream names were computed at module load from it. GAQ was namespaceable for a shared Redis, but always via a **static** prefix resolved once — never per-publish/dynamic. This PR keeps that model and merely also allows the prefix to be a zero-argument callable (resolved once at `init_app`), a strict superset of the old static string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
