villebro commented on PR #43843: URL: https://github.com/apache/superset/pull/43843#issuecomment-5534448389
Thanks for the automated reviews. Addressed in fc0ed77: **"A callable prefix could resolve differently per publish, desyncing from the consumer's single subscription"** (codeant on `manager.py`/`index.ts`, bito) — valid concern. A realtime channel is a deployment-level namespace, not a per-message value, so there's no reason to re-evaluate it on every publish. The prefix is now resolved **once at `init_app`** (string, or a zero-argument callable evaluated there) and stored as a string, exactly like the sibling `TASKS_ABORT_CHANNEL_PREFIX` / `TASKS_COMPLETION_CHANNEL_PREFIX`. The channel is therefore fixed for the process lifetime and stays in lockstep with the consumer's fixed subscription. **"`REALTIME_CHANNEL_PREFIX=\"\"` can't clear a nonempty prefix from the config file"** (codeant on `config.ts`) — technically true, but this is the established behavior of `applyEnvOverrides` for *every* string field (an empty/whitespace env value is skipped via `isPresent`); "empty means unset" is the override map's contract. Special-casing this one key would be inconsistent, and an operator who set the prefix in the config file can remove it there. Leaving as-is by design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
