mikebridge commented on PR #42540:
URL: https://github.com/apache/superset/pull/42540#issuecomment-5543817440
@aminghadersohi — added your optional test nit; the `_feature_value`
fallback is now pinned. Head: `4a8c44af75`.
You were right that the non-string branch was unexercised — reverting the
call site to the old inline `getattr(feature, "value", feature)` form left all
103 tests green. Added
`test_semantic_view_data_features_coerces_non_string_member`: a
`frozenset({SemanticViewFeature.GROUP_LIMIT, 7})` asserting the serialized
payload is `["7", "GROUP_LIMIT"]`. Verified the control — against the
pre-helper inline form it now **fails** with `TypeError: '<' not supported
between instances of 'int' and 'str'` (the mixed-type `sorted()`), so the
`str(value)` fallback is genuinely covered.
Changed-file pre-commit clean (ruff/ruff-format/mypy).
Your earlier approve went stale when the mypy `_feature_value` commit moved
the head — would you mind re-approving at `4a8c44af75` so this can merge?
Thanks.
_Reply generated by Claude (AI) on behalf of @mikebridge._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
