sadpandajoe commented on PR #42404: URL: https://github.com/apache/superset/pull/42404#issuecomment-5547006880
@rusackas — pushed cd9b25e2c0 addressing both points from your last review: - **Workflow rollback**: `.github/workflows` is restored to the merge-base state via `git checkout origin/master -- .github`. The diff no longer touches action pins, the `ubuntu-slim` runners, or the liccheck `pkg_resources` shim, so `python-dependency-liccheck` should pass now. - **UPDATING.md wording**: reworded to describe this PR as tightening edit/delete to editors-or-Admins, rather than implying themes were previously admin-only — confirmed `Theme` is in `GAMMA_READ_ONLY_MODEL_VIEWS`, so Alpha already had `can_write` on it before this change. Verified the single-Alembic-head state and the `down_revision` test are both still intact, and pre-commit (including zizmor on the workflow files) is clean on the touched files. Would appreciate a re-review when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
