bito-code-review[bot] commented on PR #43935:
URL: https://github.com/apache/superset/pull/43935#issuecomment-5554137551
<!-- Bito Reply -->
The current implementation accepts `**kwargs` in
`SupersetMetastoreCache.__init__` but does not pass them to `super().__init__`.
To ensure `ignore_delete_many_errors` is correctly utilized by `BaseCache`, you
should update the constructor to pass `**kwargs` to the superclass. The
regression test should then be updated to assert that the `BaseCache` instance
correctly receives and applies these options.
**superset/extensions/metastore_cache.py**
```
) -> None:
super().__init__(default_timeout, **kwargs)
self.namespace = namespace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
