sadpandajoe commented on code in PR #43935:
URL: https://github.com/apache/superset/pull/43935#discussion_r3941750350
##########
superset/extensions/metastore_cache.py:
##########
@@ -44,6 +44,7 @@ def __init__(
namespace: UUID,
codec: KeyValueCodec,
default_timeout: int = 300,
+ **kwargs: Any,
Review Comment:
The new signature accepts these options, but
`super().__init__(default_timeout)` discards them. A `CACHE_CONFIG` setting of
`ignore_delete_many_errors=False` is silently changed to `True`, so
`delete_many()` will not raise when a delete fails; should these kwargs be
forwarded to `BaseCache` and the regression assert that behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
