bito-code-review[bot] commented on PR #43978:
URL: https://github.com/apache/superset/pull/43978#issuecomment-5577856562
<!-- Bito Reply -->
The flagged issue is correct. By unconditionally setting `getPopupContainer`
to `document.body`, the component ignores the `isOverflowingFilterBar` logic
that previously scoped the popup container to the parent node when overflowing.
This bypasses the intended stacking context and causes overflow tests to fail.
To resolve this, restore the conditional logic for `getPopupContainer` to
ensure the popup is scoped correctly based on the overflow state:
```tsx
getPopupContainer={nodeTrigger =>
isOverflowingFilterBar
? (nodeTrigger.parentNode as HTMLElement)
: document.body
}
```
I have validated this fix against the provided diff. Would you like me to
fetch all other comments on this PR to check if you want to address them as
well?
**superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx**
```
getPopupContainer={nodeTrigger =>
isOverflowingFilterBar
? (nodeTrigger.parentNode as HTMLElement)
: document.body
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
