bito-code-review[bot] commented on code in PR #43978:
URL: https://github.com/apache/superset/pull/43978#discussion_r3953640255
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -368,11 +368,7 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
onOpenChange={toggleOverlay}
overlayStyle={{ width: 'min(600px, calc(100vw - 32px))' }}
destroyOnHidden
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
- }
+ getPopupContainer={() => document.body}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Stale tests fail CI</b></div>
<div id="fix">
This change makes the popover always attach to `document.body`, but the
existing tests in `DateFilterLabel.test.tsx` (lines 166-201) still assert that
when `isOverflowingFilterBar` is true the popover attaches to
`trigger.parentElement`. Those tests will now fail in CI. Please update them to
reflect the new always-`document.body` behavior.
</div>
</div>
<small><i>Code Review Run #7648f7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
