sadpandajoe commented on code in PR #43737:
URL: https://github.com/apache/superset/pull/43737#discussion_r3974735623
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -686,6 +851,13 @@ def merge_chart_form_data( # noqa: C901
"""
if existing_form_data.get("viz_type") != new_form_data.get("viz_type"):
return dict(new_form_data)
+ if isinstance(config, GanttChartConfig):
+ merged = dict(new_form_data)
Review Comment:
This update starts from the newly mapped form data, but `map_gantt_config`
always emits default `tooltip_columns`, `tooltip_metrics`, `order_by_cols`, and
`row_limit` even when those fields were omitted. Updating only a presentation
field therefore clears saved tooltips/sort and resets a saved row limit, unlike
the normal same-viz merge path. Could this preserve omitted Gantt query
controls (or map only fields explicitly supplied) so a partial update does not
mutate them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
