sadpandajoe commented on code in PR #43737:
URL: https://github.com/apache/superset/pull/43737#discussion_r3974768282
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -686,6 +851,13 @@ def merge_chart_form_data( # noqa: C901
"""
if existing_form_data.get("viz_type") != new_form_data.get("viz_type"):
return dict(new_form_data)
+ if isinstance(config, GanttChartConfig):
+ merged = dict(new_form_data)
+ if not dataset_rebind:
Review Comment:
The dataset-rebind branch intentionally drops saved Gantt series and
filters, but the Gantt suite does not exercise that boundary. Could we add a
regression that updates a saved Gantt chart to a different dataset with an old
series/filter and asserts both preview and persisted form data contain neither
old reference (except the new generated temporal binding)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
