bito-code-review[bot] commented on PR #44127: URL: https://github.com/apache/superset/pull/44127#issuecomment-5612063861
<!-- Bito Reply --> The flagged issue is correct. Describing the 'Show values as' control as display-only is misleading because it can trigger additional database rollup queries to calculate totals and subtotals, which may impact performance or cause failures if those queries fail. To resolve this, the documentation should clarify that this control involves data processing beyond simple formatting. Would you like me to implement this fix in the documentation, and would you like me to check the rest of the comments on this PR for similar issues? **docs/docs/using-superset/exploring-data.mdx** ``` :::note Totals and subtotals are computed via database rollup queries. **Show values as** changes how these computed values are displayed as percentages. Because the result is always a percentage, a per-metric custom formatter (currency, decimal precision, etc.) doesn't apply while a fraction option is selected. ::: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
