rusackas commented on code in PR #44127: URL: https://github.com/apache/superset/pull/44127#discussion_r3978307885
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -165,6 +165,16 @@ control can override a simple metric's own aggregation (to Sum or Average) for t only — metrics built from custom SQL keep their own aggregation regardless. ::: +In the **Options** panel, the **Show values as** control displays each cell as a percentage of its +row total, column total, or grand total instead of its actual value: + +:::note +Totals and subtotals are still computed correctly first, as described above; **Show values as** +only changes how the already-correct cell, row-total, column-total, and grand-total values are +displayed. Because the result is always a percentage, a per-metric custom formatter (currency, +decimal precision, etc.) doesn't apply while a fraction option is selected. Review Comment: Fair catch — switching this control isn't a renderTrigger, so it re-runs the query, and for non-additive metrics can pull in an extra rollup level for the percentage denominator. Reworded the note to say so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
