varadendrasimha511 commented on PR #43457: URL: https://github.com/apache/superset/pull/43457#issuecomment-5612711290
@rusackas Thanks for the context — that makes sense, and I hadn't seen #43481. A couple of clarifying questions so I scope this correctly: 1. If getCellColor is never called on pvtTotal cells at the renderer level, then no calibration-domain change (mine or otherwise) can actually make totals render with color — so it sounds like the original premise behind #43084 (large totals appearing uncolored) may now be resolved by design, not by a fix. Is that a fair read? 2. If so, is there still a narrower gap worth fixing here — e.g., forced-in percent-denominator rows (from showValuesAs with totals toggled off) that aren't pvtTotal cells per se, but are synthetic rows that could still leak into calibration and skew coloring for genuine leaf-level cells? Or does #43481's exclusion logic already cover that case too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
