rusackas commented on PR #43457: URL: https://github.com/apache/superset/pull/43457#issuecomment-5667790719
@varadendrasimha511 yeah, that's a fair read, the #43084 case is resolved by design rather than by this fix, coloring the totals would need a renderer change that actually calls `getCellColor` on the `pvtTotal` cells. On the second question I don't think there's a gap left. The forced-in percent denominator level only collapses one axis (all rows or all columns), it's never the full leaf grouping, so it's never what `colorScaleRows` picks up since that always resolves to the leaf level. Should already be covered by #43481. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
