codeant-ai-for-open-source[bot] commented on code in PR #44131:
URL: https://github.com/apache/superset/pull/44131#discussion_r3975969341
##########
.github/workflows/superset-e2e.yml:
##########
@@ -114,13 +114,13 @@ jobs:
submodules: recursive
# -------------------------------------------------------
- name: Setup Python
- uses: ./.github/actions/setup-backend/
+ uses: $/.github/actions/setup-backend/
- name: Setup postgres
- uses: ./.github/actions/cached-dependencies
+ uses: $/.github/actions/cached-dependencies
Review Comment:
Yes. The `cached-dependencies` references should remain workspace-relative
because the action lives in a checked-out submodule. Keep these as:
```yaml
uses: ./.github/actions/cached-dependencies
```
The `$/.github/...` form is appropriate for actions in the main repository
tree, but it does not address the submodule-backed action preparation issue.
Add a narrowly scoped zizmor suppression for the affected `uses` entries, for
example:
```yaml
# zizmor: ignore[self-repository] -- cached-dependencies is a checked-out
submodule
- uses: ./.github/actions/cached-dependencies
```
Apply this only to the `cached-dependencies` references; the other local
composite actions should retain the new self-repository syntax. This preserves
the required submodule resolution while keeping the zizmor scan clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
