rusackas commented on code in PR #44131:
URL: https://github.com/apache/superset/pull/44131#discussion_r3978215126
##########
.github/workflows/superset-e2e.yml:
##########
@@ -114,13 +114,13 @@ jobs:
submodules: recursive
# -------------------------------------------------------
- name: Setup Python
- uses: ./.github/actions/setup-backend/
+ uses: $/.github/actions/setup-backend/
- name: Setup postgres
- uses: ./.github/actions/cached-dependencies
+ uses: $/.github/actions/cached-dependencies
Review Comment:
Done, kept those workspace-relative with the zizmor suppression per your
suggestion.
##########
.github/workflows/superset-helm-lint-test.yml:
##########
@@ -49,7 +49,7 @@ jobs:
# allowlist (only v8.1.0+ are, at apache/infrastructure-actions'
# actions.yml). Needs an INFRA request before this can de-vendor too.
- name: Set up chart-testing
- uses: ./.github/actions/chart-testing-action
+ uses: $/.github/actions/chart-testing-action
Review Comment:
Fixed, reverted to ./ with a zizmor suppression, same as the other
submodule-backed local actions.
##########
.github/workflows/pr-lint.yml:
##########
@@ -34,7 +34,7 @@ jobs:
with:
persist-credentials: false
submodules: recursive
- - uses: ./.github/actions/pr-lint-action
+ - uses: $/.github/actions/pr-lint-action
Review Comment:
Fixed, back to ./.github/actions/pr-lint-action with a zizmor suppression.
##########
.github/workflows/scheduled-docker-image-refresh.yml:
##########
@@ -119,7 +119,7 @@ jobs:
sparse-checkout: .github/actions
- name: Setup Docker Environment
- uses: ./workflow-source/.github/actions/setup-docker
+ uses: $/workflow-source/.github/actions/setup-docker
Review Comment:
Kept these workspace-relative, didn't want to touch the extra checkout
mechanism in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
