sha174n commented on PR #43060: URL: https://github.com/apache/superset/pull/43060#issuecomment-5617399749
Pushed cc908d292c, with current master merged in. Two cleanups from another pass over the diff: the setting-name normalization that was inlined in three places is now one helper, and `changes_search_path` no longer repeats the opaque-`SET` guard that helper already performs. `changes_default_schema` also matches a `SET SCHEMA` / `SET CATALOG` carried in a body the parser leaves opaque, which `SET search_path` in the same body was already matched on. The `SET` head is required there, so a body that merely creates or references a schema is unaffected. New cases in `test_changes_default_schema`; `superset/sql/` still at 100% coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
