bito-code-review[bot] commented on code in PR #44154:
URL: https://github.com/apache/superset/pull/44154#discussion_r3984944104
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -333,6 +334,8 @@ const SliceHeaderControls = (
props.slice.slice_name,
true,
theme,
+ undefined,
+ props.addWarningToast,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken existing tests</b></div>
<div id="fix">
These calls now pass extra args (`undefined`, `props.addWarningToast`) to
`downloadAsImage`/`downloadAsPdf`, but `SliceHeaderControls.test.tsx` (not
updated in this diff) asserts exact argument lists via `toHaveBeenCalledWith`
at lines 881/910/933/955. Jest does exact matching, so these tests will fail.
Update the assertions to include the new arguments.
</div>
</div>
<small><i>Code Review Run #77d8fb</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
