bito-code-review[bot] commented on code in PR #44154:
URL: https://github.com/apache/superset/pull/44154#discussion_r3986254788
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -333,6 +334,8 @@ const SliceHeaderControls = (
props.slice.slice_name,
true,
theme,
+ undefined,
+ props.addWarningToast,
Review Comment:
<!-- Bito Reply -->
The update to the test assertions is appropriate. By including `undefined`
and `props.addWarningToast` in the `toHaveBeenCalledWith` calls, the tests now
correctly match the updated function signatures in the component, ensuring the
test suite remains passing.
**superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx**
```
props.slice.slice_name,
true,
theme,
+ undefined,
+ props.addWarningToast,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
