EnxDev commented on code in PR #44113:
URL: https://github.com/apache/superset/pull/44113#discussion_r3987853065


##########
superset/mcp_service/mcp_config.py:
##########
@@ -204,6 +204,7 @@ class MCPAuthConfigError(ValueError):
 MCP_GUEST_ALLOWED_TOOLS: set[str] = {
     "get_dashboard_info",
     "get_dashboard_layout",
+    "get_dashboard_data",

Review Comment:
   **[P2] Please keep the MCP docs in sync with this new guest-visible tool.** 
The operator guide copies this default allow-list verbatim in 
`docs/admin_docs/configuration/mcp-server.mdx`, so after this addition its 
documented default is stale. The same guide also needs `get_dashboard_data` in 
the RBAC table with both Dashboard and Chart read requirements, and the 
user-facing tool catalog in 
`docs/docs/using-superset/using-ai-with-superset.mdx` does not list the new 
dashboard tool. Could we update those entries in this PR so users and operators 
can discover and configure the API accurately?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to