gabotorresruiz commented on code in PR #44113:
URL: https://github.com/apache/superset/pull/44113#discussion_r3990196211
##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -2450,3 +2450,138 @@ class RestoreDashboardResponse(BaseModel):
"not retry; ask the user)."
),
)
+
+
+class GetDashboardDataRequest(BaseModel):
+ """Request schema for get_dashboard_data."""
+
+ model_config = ConfigDict(populate_by_name=True)
+
+ identifier: int | str = Field(
+ ...,
+ description="Dashboard identifier - numeric ID, UUID string, or slug.",
+ validation_alias=AliasChoices("identifier", "id", "dashboard_id"),
Review Comment:
Good catch, valid. `bool` is an `int` subclass, so `identifier=true` coerced
to `1`. Added a `reject_bool_identifier` field validator on
`GetDashboardDataRequest` (matching the existing guard on the chart request
schemas), which rejects `bool` outright. Pinned by
`test_rejects_bool_identifier`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
