mikebridge opened a new pull request, #44181:
URL: https://github.com/apache/superset/pull/44181
### SUMMARY
Four design-parity fixes to the version-history panel (the `VERSION_HISTORY`
UI shipped in #41551), found by QA against the Figma "Version History" spec.
All four are presentation-only — no behavior, API, or state changes:
1. **Current version highlighted at rest.** The green "active version"
treatment (background, icon accent, timeline dot) previously appeared only
while previewing a historical version; at rest the current version showed only
a small grey "Current" tag, so users could not tell which version they were on.
The current (live) version now carries exactly the same active treatment at
rest that a historical version gets while previewed — one consistent "you are
here" state, driven by the theme's primary tokens (`colorPrimaryBg` /
`colorPrimary`), no hardcoded colors.
2. **Explore preview banner no longer collapses.** In narrow hosts
(Explore's chart column can be under 500px) the banner's no-shrink action
buttons crushed the message column to ~40px, wrapping the text one word per
line. The banner's action slot now wraps under the message when a single row
does not fit — a no-op at dashboard widths, where the banner renders exactly as
before.
3. **Semantic group icons.** Group headers used a generic calendar icon for
every group; per the design, the current version now shows a check-circle and
historical snapshots a save icon.
4. **Row overflow ("⋮") accent.** The per-row overflow trigger takes the
theme's primary accent (`colorPrimary`, `colorPrimaryActive` on hover) instead
of neutral grey, per the design's treatment of row actions.
Alongside, the `ActionRow` prop that drives the timeline dot was renamed
`isPreviewed` → `isHighlighted` to match its actual contract (active for the
current version at rest *or* a previewed version); `SaveGroupItem` is its only
consumer.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
QA's "before" evidence (current version grey at rest; Explore banner
collapsed to one word per line; calendar icons; grey kebab) is attached to the
originating tickets. After-screenshots from a live build to follow in a comment.
### TESTING INSTRUCTIONS
Automated:
```bash
cd superset-frontend
npm run test -- src/features/versionHistory/
# 17 suites / 188 tests, including new coverage:
# - current-at-rest carries the same treatment as previewed (and resting
history does not)
# - semantic icons: check-circle for current, save for history
# - current group's rows show the active timeline dot at rest
# - the banner's action slot wraps instead of crushing the message
```
Manual (any instance with `VERSION_HISTORY` on and a chart with history):
1. Explore the chart → "…" → View version history: the current version's row
is green-highlighted at rest with a check-circle icon; historical groups show a
save icon; row "⋮" icons render in the theme's primary color.
2. Click a historical change to preview: the previewed group takes the
highlight; the banner at the top shows its message on readable lines with the
actions beside it (or wrapped below it when the column is narrow) — never one
word per line.
3. On a dashboard, the preview banner is unchanged (single row at full
width).
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
- [ ] Has associated issue:
- [x] Required feature flags: `VERSION_HISTORY`
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01C7U5oFfrqUyM6hJTZiW2uf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
