mikebridge commented on PR #44181:
URL: https://github.com/apache/superset/pull/44181#issuecomment-5643966758

   Before/after screenshots for the four QA fidelity fixes in this PR, captured 
on the local dev stack (chart Explore, admin fixture). "Before" is `master` 
with this PR's `versionHistory` directory reverted; "after" is this branch.
   
   ### Panel at rest — current-group treatment + semantic icons
   
   The current save group gets the primary-color background tint and a 
check-circle icon; historical groups get the save icon (previously both used 
the generic calendar icon with no current-group treatment).
   
   | Before | After |
   |---|---|
   | ![before 
panel](https://raw.githubusercontent.com/mikebridge/superset/sc-119620-assets/before-panel-at-rest.png)
 | ![after 
panel](https://raw.githubusercontent.com/mikebridge/superset/sc-119620-assets/after-panel-at-rest.png)
 |
   
   Full-resolution detail of the after state (icons, Current tag, 
primary-colored kebab triggers):
   
   <img 
src="https://raw.githubusercontent.com/mikebridge/superset/sc-119620-assets/after-panel-detail.png";
 width="420" alt="after panel detail" />
   
   ### Preview state — exclusive highlight
   
   While previewing a historical version, exactly one group is highlighted: the 
highlight moves to the previewed group and the current group returns to its 
resting style.
   
   | Before | After |
   |---|---|
   | ![before 
preview](https://raw.githubusercontent.com/mikebridge/superset/sc-119620-assets/before-preview.jpg)
 | ![after 
preview](https://raw.githubusercontent.com/mikebridge/superset/sc-119620-assets/after-preview.jpg)
 |
   
   ### Preview banner at narrow width
   
   At the QA-reported narrow width the banner message previously wrapped into a 
cramped multi-line column beside the buttons; the actions row itself now wraps 
below the message and nothing is clipped.
   
   | Before | After |
   |---|---|
   | ![before 
banner](https://raw.githubusercontent.com/mikebridge/superset/sc-119620-assets/before-banner-narrow.png)
 | ![after 
banner](https://raw.githubusercontent.com/mikebridge/superset/sc-119620-assets/after-banner-narrow.png)
 |
   
   ---
   
   *This comment was generated by Claude (AI) on behalf of @mikebridge.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to