codeant-ai-for-open-source[bot] commented on code in PR #44089:
URL: https://github.com/apache/superset/pull/44089#discussion_r3995235519
##########
superset/versioning/changes/shadow_queries.py:
##########
@@ -317,8 +340,14 @@ def _dashboard_child_records_for_tx_from_shadows(
if prior_tx is None:
continue
- post_uuids = _dashboard_slice_uuids_at_tx(session, dashboard_id,
transaction_id)
- pre_uuids = _dashboard_slice_uuids_at_tx(session, dashboard_id,
prior_tx)
+ # Resolve the attachment windows once (threading the committing
+ # *session* so the flushed-but-uncommitted current-tx association rows
+ # are visible), then take the pre/post membership by which windows
+ # contain each tx โ the windows are tx-independent, so no need to
+ # re-scan the association history for both reads.
+ attached = charts_attached_to_dashboard(dashboard_id, session=session)
+ post_uuids = _dashboard_slice_uuids_at_tx(session, attached,
transaction_id)
+ pre_uuids = _dashboard_slice_uuids_at_tx(session, attached, prior_tx)
Review Comment:
**Suggestion:** Each affected dashboard now loads its complete attachment
history and performs additional slice scans during commit finalization, causing
multiple extra queries and Python sorting per dashboard. [performance]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ee3a55bea0474619add57ecd7e3658ec&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ee3a55bea0474619add57ecd7e3658ec&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/versioning/changes/shadow_queries.py
**Line:** 348:350
**Comment:**
*Performance: Each affected dashboard now loads its complete attachment
history and performs additional slice scans during commit finalization, causing
multiple extra queries and Python sorting per dashboard.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44089&comment_hash=1e32c925fee6727a86ef88af6c63a3acbea7f73cda1eec877e4b3ca413ed6cc4&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44089&comment_hash=1e32c925fee6727a86ef88af6c63a3acbea7f73cda1eec877e4b3ca413ed6cc4&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
