bito-code-review[bot] commented on PR #44089:
URL: https://github.com/apache/superset/pull/44089#issuecomment-5643717769
<!-- Bito Reply -->
The flagged performance issue is a deliberate design choice to ensure data
consistency during commit finalization. The implementation correctly uses the
committing session to read flushed-but-uncommitted association rows, which is
necessary to avoid missing changes that would occur if the global `db.session`
were used. The additional queries and sorting are mitigated by chunking the
`IN` clauses to stay under the SQLite bind-variable limit, mirroring existing
patterns in the codebase. No further resolution is required as this is the
intended behavior for maintaining accurate change records.
**superset/versioning/changes/shadow_queries.py**
```
# Resolve each attached chart's uuid from the content shadow at tx. The id
# set is a dashboard's simultaneous membership at one tx (realistically
# dozens), but chunk the IN anyway to stay under SQLite's bind-variable
# floor, mirroring the sibling impact rollup (#44010).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
