hainenber opened a new pull request, #44201: URL: https://github.com/apache/superset/pull/44201
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> feat(build): migrate custom lint rule to Oxlint ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Migrate existing lint rule from ESLint-based to Oxlint-based. Well, not that much of a refactor since Oxlint folks provides excellent compatibility with custom ESLint plugin API. A bit of shame that module-level, Typescript-based custom JS plugin support for Oxlint is not yet mature so I had to use jsdoc to annotate typing for TS-to-JS plugin files but not a dealbreaker, tbh. I also fixed the typescript rule in existing `oxlint.json` from `@typescript-eslint` to `typescript` prefix. The ESLint config and script to run and parse Oxlint for metrics uploader is also revamped since we consolidate to Oxlint finally, reducing code paths. `npm run check:custom-rules` is still good. The plugin files are still intact with their logic <img width="774" height="777" alt="image" src="https://github.com/user-attachments/assets/ce617405-fcb4-4492-91bd-39332e9c534c"; /> Running rule tests with native `node:test` is super fun and good, ensuring no regression <img width="773" height="830" alt="image" src="https://github.com/user-attachments/assets/c52e57d7-f84f-4a6b-8f43-ab2304aee9ee"; /> Running the lint config only for custom rules is also all fine and dandy. It detected correctly violations <img width="765" height="747" alt="image" src="https://github.com/user-attachments/assets/2ad3da3c-26c2-47a7-9088-ee1ed482b271"; /> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Green CI ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
