codeant-ai-for-open-source[bot] commented on code in PR #44201:
URL: https://github.com/apache/superset/pull/44201#discussion_r3995818934
##########
.github/workflows/superset-frontend.yml:
##########
@@ -153,10 +153,11 @@ jobs:
run: |
zstd -d < docker-image.tar.zst | docker load
+ # The last weird node command is to run tests fo custom Superset lint
rules
- name: lint
run: |
docker run --rm $TAG bash -c \
- "npm i && npm run lint"
+ "npm i && npm run lint && node --import tsx --test
custom-lint-rules/**/*.test.ts"
Review Comment:
**Suggestion:** The workflow runs only the standard Oxlint config and unit
tests, so custom-rule violations in frontend source no longer fail CI.
[incomplete implementation]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=94ddd7c3c3b24fcd8bc799ef2260f40a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=94ddd7c3c3b24fcd8bc799ef2260f40a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .github/workflows/superset-frontend.yml
**Line:** 160:160
**Comment:**
*Incomplete Implementation: The workflow runs only the standard Oxlint
config and unit tests, so custom-rule violations in frontend source no longer
fail CI.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44201&comment_hash=9615718d52dfb359d4e3a9d00f0253fc295fab1a07f05417ef6d7aa985492cf2&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44201&comment_hash=9615718d52dfb359d4e3a9d00f0253fc295fab1a07f05417ef6d7aa985492cf2&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
