codeant-ai-for-open-source[bot] commented on code in PR #44237:
URL: https://github.com/apache/superset/pull/44237#discussion_r4005429664
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -179,45 +180,47 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
setValidTimeRange(true);
return;
}
- fetchTimeRange(value).then(({ value: actualRange, error }) => {
- if (error) {
- setEvalResponse(error || '');
- setValidTimeRange(false);
- setTooltipTitle(t(value) || null);
- } else {
- /*
- HRT == human readable text
- ADR == actual datetime range
- +--------------+------+----------+--------+----------+-----------+
- | | Last | Previous | Custom | Advanced | No Filter |
- +--------------+------+----------+--------+----------+-----------+
- | control pill | HRT | HRT | ADR | ADR | HRT |
- +--------------+------+----------+--------+----------+-----------+
- | tooltip | ADR | ADR | HRT | HRT | ADR |
- +--------------+------+----------+--------+----------+-----------+
- */
- if (
- guessedFrame === 'Common' ||
- guessedFrame === 'Calendar' ||
- guessedFrame === 'Current' ||
- guessedFrame === 'No filter'
- ) {
- setActualTimeRange(value);
- setTooltipTitle(
- getTooltipTitle(labelIsTruncated, value, actualRange),
- );
+ fetchTimeRange(value, 'col', undefined, displayFormat).then(
+ ({ value: actualRange, error }) => {
Review Comment:
**Suggestion:** Overlapping requests can resolve out of order, so an older
value or format can overwrite the pill, tooltip, validation state, and fetch
marker for the current selection. [race condition]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=10fbd8edf970457f850e7a72e46d776b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=10fbd8edf970457f850e7a72e46d776b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
**Line:** 183:184
**Comment:**
*Race Condition: Overlapping requests can resolve out of order, so an
older value or format can overwrite the pill, tooltip, validation state, and
fetch marker for the current selection.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44237&comment_hash=c16089e98747ea9a2912f240739d723bf422b747cdd22a48334a84a797e3fca2&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44237&comment_hash=c16089e98747ea9a2912f240739d723bf422b747cdd22a48334a84a797e3fca2&reaction=dislike'>๐</a>
##########
superset-frontend/src/filters/components/Time/TimeFilterPlugin.tsx:
##########
@@ -131,6 +131,7 @@ export default function TimeFilterPlugin(props:
PluginFilterTimeProps) {
unsetFocusedFilter();
}}
isOverflowingFilterBar={isOverflowingFilterBar}
+ displayFormat={props.formData.displayFormat}
Review Comment:
**Suggestion:** The extension registry contract does not declare
`displayFormat`, so custom date-filter controls cannot discover or type this
prop and silently ignore the configured format. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6e88610489034f6f8eb6b9bac1b24037&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6e88610489034f6f8eb6b9bac1b24037&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/filters/components/Time/TimeFilterPlugin.tsx
**Line:** 134:134
**Comment:**
*Api Mismatch: The extension registry contract does not declare
`displayFormat`, so custom date-filter controls cannot discover or type this
prop and silently ignore the configured format.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44237&comment_hash=cfb2c97d2d00f01512a61e258b6faeac9b6db27738b6cd4c829904b0a379e6b9&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44237&comment_hash=cfb2c97d2d00f01512a61e258b6faeac9b6db27738b6cd4c829904b0a379e6b9&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
