Ujjwaljain16 commented on PR #44237: URL: https://github.com/apache/superset/pull/44237#issuecomment-5680067973
Checked all three — none hold up: - `formatTimeRangeComparison` not getting `dateFormat`: true on paper, but the `shifts` branch has zero production callers right now, so it's dead code, not a reachable bug. - Missing `defaultDataMask` reset on display format change: the live preview already updates via `forceUpdate()` + a fresh `formData` recompute. Resetting the mask would just wipe the user's applied value for no reason — display format is purely cosmetic, doesn't touch the value. - Missing `filterOption`: `SelectControl` already defaults to `filterOption: true`, which filters by label/value out of the box. The explicit one on `x_axis_time_format` is redundant, not required. Leaving these as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
