bito-code-review[bot] commented on PR #44173:
URL: https://github.com/apache/superset/pull/44173#issuecomment-5666407888
<!-- Bito Reply -->
The flagged issue is correct. The current implementation of `setThemeConfig`
unconditionally sets `themeConfigOverride` to `true` whenever it is called,
which causes the issue described where repeated SDK calls (even with default
values) suppress dashboard themes. The provided PR diff already implements the
fix by introducing an `isExplicitOverride` check using `isEqual` to compare the
incoming config against the workspace defaults, ensuring the override flag is
only set when the configuration actually differs from the default.
**superset-frontend/src/theme/ThemeController.ts**
```
// Only a config that differs from the workspace default is an explicit
// override; an auto-forwarded default must not suppress the dashboard
theme.
const isExplicitOverride =
!isEqual(config.theme_default, this.defaultTheme) ||
!isEqual(config.theme_dark || null, this.darkTheme);
this.defaultTheme = config.theme_default;
this.darkTheme = config.theme_dark || null;
this.themeConfigOverride = isExplicitOverride;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
