codeant-ai-for-open-source[bot] commented on code in PR #44173:
URL: https://github.com/apache/superset/pull/44173#discussion_r4006759752
##########
superset-frontend/src/theme/ThemeController.ts:
##########
@@ -554,9 +555,15 @@ export class ThemeController {
* @param config - The complete theme configuration object
*/
public setThemeConfig(config: SupersetThemeConfig): void {
+ // Only a config that differs from the workspace default is an explicit
+ // override; an auto-forwarded default must not suppress the dashboard
theme.
+ const isExplicitOverride =
+ !isEqual(config.theme_default, this.defaultTheme) ||
+ !isEqual(config.theme_dark || null, this.darkTheme);
Review Comment:
**Suggestion:** After one custom config, a repeated identical SDK call
compares against the already-overridden themes and clears
`themeConfigOverride`, allowing dashboard themes to reappear unexpectedly.
[stale reference]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=bba9c672c31e439cb696e5035825ceeb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=bba9c672c31e439cb696e5035825ceeb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/theme/ThemeController.ts
**Line:** 560:562
**Comment:**
*Stale Reference: After one custom config, a repeated identical SDK
call compares against the already-overridden themes and clears
`themeConfigOverride`, allowing dashboard themes to reappear unexpectedly.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44173&comment_hash=56d40ac546c5342aba1a996025c4af1f33ae4eae2ae6bd975e46910409d21b3e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44173&comment_hash=56d40ac546c5342aba1a996025c4af1f33ae4eae2ae6bd975e46910409d21b3e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
