mikebridge commented on code in PR #44021:
URL: https://github.com/apache/superset/pull/44021#discussion_r4007431420
##########
superset/versioning/activity/render.py:
##########
@@ -183,8 +183,8 @@ def apply_record_decoration(
# "(deleted) <kind>" marker — so the stream stays honest
# about WHEN something changed without disclosing WHAT, WHO,
# or WHICH entity. Self-path tombstones are untouched: the
- # endpoint already gated them via ``raise_for_access`` on the
- # path entity.
+ # endpoint already gated them via ``raise_for_editorship``
Review Comment:
Agreed — real, and inherited: related-entity records are filtered for
*presence* by the read-based visibility filter, but `changed_by` and the
field-level `from`/`to` diffs ride along regardless of whether the reader can
edit the related entity. This PR deliberately gates on the path entity only (as
scoped in the body), so I've left it untouched here rather than widen the
change. Tracked as a follow-up to extend the edit-gate decision to
related-record detail — redact/drop `changed_by` and the diff fields when the
reader is not an editor of the related entity, keep presence filtering as-is —
with a test that pins the editor-vs-reader split (sc-120470). Thanks for naming
it as a residual rather than letting it pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
