gabotorresruiz commented on PR #44021: URL: https://github.com/apache/superset/pull/44021#issuecomment-5688570419
Question on symmetry now that this is merged, not urgent: the new gate refuses guests categorically before `raise_for_editorship`, but the restore command still gates on `raise_for_editorship` alone (`superset/commands/version_restore.py`), and `is_editor`'s guest branch maps guest role subjects. So a guest whose role subject holds editorship can restore a version whose history it cannot read. If restore should refuse guests too, the same categorical check would fit in `RestoreVersionCommand.validate`, with a sibling of `test_editorship_gate_refuses_guest_principal` pinning it. Was the asymmetry deliberate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
