aminghadersohi commented on code in PR #43838:
URL: https://github.com/apache/superset/pull/43838#discussion_r4007591773
##########
superset/versioning/activity/render.py:
##########
@@ -168,7 +167,7 @@ def apply_record_decoration(
record["impact"] = None
else:
record["summary"] = _build_summary(api_kind, record)
- record["impact"] = impact_for_record(record, path_kind,
impact_counts)
+ record["impact"] = impact_for_record(record, path_kind,
impact_refs)
Review Comment:
Re codeant's `Major` above: net-zero for live members —
`daos/dashboard.py:218` returns `dashboard.slices` raw (no `ChartFilter`), and
`GET /api/v1/dashboard/{id}/charts` already serves every member chart to any
principal with dashboard read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
