mikebridge commented on code in PR #43838:
URL: https://github.com/apache/superset/pull/43838#discussion_r4007969631
##########
superset/versioning/activity/render.py:
##########
@@ -168,7 +167,7 @@ def apply_record_decoration(
record["impact"] = None
else:
record["summary"] = _build_summary(api_kind, record)
- record["impact"] = impact_for_record(record, path_kind,
impact_counts)
+ record["impact"] = impact_for_record(record, path_kind,
impact_refs)
Review Comment:
Decision recorded in the redaction block (0ef8714a92): `impact` is
deliberately kept. It names the *path* dashboard's own member charts — which
`raise_for_access` already gates, and version history is itself edit-gated
(sc-120001) — not the deleted related entity or its editors, which is what the
block withholds. Chart titles are visible to a dashboard's viewers today
regardless of datasource access, and the historical members are the dashboard's
own history, so naming them discloses nothing a requester entitled to the path
entity can't already see (the count was never redacted for the same reason).
And "a dataset was deleted — which of my charts broke?" is the primary use of
the impact detail — exactly the tombstoned case — so redacting there would gut
it. Agree it isn't a SECURITY.md matrix row; thanks for making us decide it
explicitly rather than leave it implicit.
##########
superset/versioning/activity/render.py:
##########
@@ -168,7 +167,7 @@ def apply_record_decoration(
record["impact"] = None
else:
record["summary"] = _build_summary(api_kind, record)
- record["impact"] = impact_for_record(record, path_kind,
impact_counts)
+ record["impact"] = impact_for_record(record, path_kind,
impact_refs)
Review Comment:
Same question as the aminghadersohi thread on this line; the decision and
rationale are recorded in the redaction block in 0ef8714a92 — `impact` is
deliberately kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
