DamianPendrak commented on PR #42372:
URL: https://github.com/apache/superset/pull/42372#issuecomment-5668247655
The grain fix works, thanks a lot @gkneighb. One remaining issue - the stale
sort key from my first comment isn't fixed yet: when the current metric (e.g.
`AVG(global_sales)`) is selected in Sort by and the metric is then changed, the
value doesn't reset and the query fails (`MIN("AVG(global_sales)")`) unless the
user clears it manually. `shouldReset` is only handled by `XAxisSortControl`,
not by `SelectControl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
