rusackas commented on PR #42372: URL: https://github.com/apache/superset/pull/42372#issuecomment-5704636668
@gkneighb thanks for keeping this moving. Agreed with @DamianPendrak on the stale sort key. As far as I can tell `shouldReset` is only honored by `XAxisSortControl`, so returning it from a `SelectControl` is a no-op, and the test only checks the flag rather than the value actually clearing. Swapping the control type to `XAxisSortControl` (same as the shared `xAxisSortControl`) seems like it'd do it. Happy to re-review once that's in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
