bito-code-review[bot] commented on PR #44274:
URL: https://github.com/apache/superset/pull/44274#issuecomment-5672652717
<!-- Bito Reply -->
The flagged issue is correct. The original implementation used a bare
`<span>` which, when wrapping empty content, results in a zero-height element.
This causes the Ant Design popover to anchor incorrectly to a point rather than
the intended trigger box. The fix implemented in the PR correctly applies
`style={{ display: 'block' }}` to the wrapper `<span>`, ensuring it has
dimensions and anchors the popover properly.
**superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx**
```
- <span>{children}</span>
+ <span style={{ display: 'block' }}>{children}</span>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
