codeant-ai-for-open-source[bot] commented on code in PR #44274:
URL: https://github.com/apache/superset/pull/44274#discussion_r4039684939
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx:
##########
@@ -201,9 +201,13 @@ const ColumnSelectPopoverTriggerInner = ({
title={popoverTitle}
destroyOnHidden
>
- {/* Wrap in span so the Popover can attach a ref without relying
- on findDOMNode (deprecated in React 18+). */}
- <span>{children}</span>
+ {/* Wrap in a span so the Popover can attach a ref without relying
+ on findDOMNode (deprecated in React 18+). It must be block-level:
+ antd anchors the popup to this element's box, and a bare inline
+ span around block content (or the empty placeholder the "add new"
+ popovers use) measures 0×0 at the control's left edge, which
+ renders the popover detached (sc-120502). */}
+ <span style={{ display: 'block' }}>{children}</span>
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> For zero-height popover trigger placeholders using right placement, do not
require artificial height; a block-level wrapper preserving the control width
is sufficient to position the popup correctly.
**Applied to:**
-
`superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
