dennisimoo commented on PR #44188: URL: https://github.com/apache/superset/pull/44188#issuecomment-5674747855
Clarified the deliberate scope in e494e56: this patch preserves the two shared controls reported in #44176, not every chart-specific presentation default. The PR description already calls this a bounded partial fix; the source comment now makes the same limit explicit. Extending this to all Pie/other mapper fields would need field-by-field reset and omission semantics rather than silently expanding this patch. The chart utility suite passes all 170 tests, and pre-commit (including mypy, Ruff, and pylint) passes. I also inspected the cancelled unit-test job: it reported 15,131 passed, 5 skipped, 2 xfailed before cancellation. The new commit should give CI a fresh run; no test or CI checks were disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
