dennisimoo commented on code in PR #44188:
URL: https://github.com/apache/superset/pull/44188#discussion_r4021532475
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -694,6 +694,11 @@ def merge_chart_form_data( # noqa: C901
if "filters" not in fields_set:
preserve_previous_adhoc_filters(new_form_data, existing_form_data)
merged = {**existing_form_data, **new_form_data}
+ # Preserve the shared color/limit controls when omitted. Chart-specific
+ # presentation defaults retain their existing mapper behavior.
+ for field in ("color_scheme", "row_limit"):
+ if field not in fields_set and field in existing_form_data:
+ merged[field] = existing_form_data[field]
Review Comment:
Fixed in 05c6a59 using exclude_unset=True across the non-Gauge normalizers.
The normalized-path regression fails before the fix; the chart suite passes
(1,638 passed, 1 skipped). Rebased onto master for #44288. Ready for another
look; could you approve the CI run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
