bito-code-review[bot] commented on PR #44244: URL: https://github.com/apache/superset/pull/44244#issuecomment-5675192242
<!-- Bito Reply --> The observation is correct. `SCREENSHOT_LOCATE_WAIT` is currently defined in `superset/config.py` but is not utilized by the Playwright implementation, making it misleading for operators. Marking it as compatibility-only or removing it alongside other legacy configuration is a sound approach to reduce confusion. **superset/config.py** ``` # "SELENIUM" in the next two key names is historical; both apply to Playwright. # Time before the headless browser times out after trying to locate an element on the # page and wait for that element to load for a screenshot. SCREENSHOT_LOCATE_WAIT = int(timedelta(seconds=10).total_seconds()) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
