sadpandajoe commented on code in PR #44244: URL: https://github.com/apache/superset/pull/44244#discussion_r4012221283
########## superset/config.py: ########## @@ -1324,11 +1324,12 @@ def sync_theme_logo_href( # - Cascade/dependent filters and search-term variants are not warmed in this # version; only base option queries are supported. -# Time before selenium times out after trying to locate an element on the page and wait -# for that element to load for a screenshot. +# Time before the headless browser times out after trying to locate an element on the Review Comment: `SCREENSHOT_LOCATE_WAIT` is only copied into `_screenshot_locate_wait`, which the Playwright path never reads, so this new comment makes an inert setting look like the browser's element-timeout control. Could we mark it as compatibility-only and point operators to the active Playwright wait settings, or remove it with the other dead screenshot config? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
