aminghadersohi opened a new pull request, #44285:
URL: https://github.com/apache/superset/pull/44285
### SUMMARY
Raise only the Presto extra's PyHive floor from 0.6.5 to 0.7.0. PyHive 0.6.5
imports the removed `sqlalchemy.databases` module, so
`create_engine("presto://...")` fails before a connection under SQLAlchemy 2.
0.7.0 is the next stable release and loads successfully.
Adds a real-dialect, socket-guarded
engine-construction/parameter-compilation regression; documents the requirement
in engine metadata, the corresponding regenerated database documentation field,
and UPDATING.md. The development lock already selects PyHive 0.7.0, so it needs
no change. Regeneration was attempted; unrelated platform/transitive drift was
discarded. No other driver, container provisioning, or harness changes.
Scoped from [SC-120252](https://app.shortcut.com/preset/story/120252).
Reconciliation confirmed #43501 and #43502 already merged; this does not
duplicate either or the Shell production-image contract.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable.
### TESTING INSTRUCTIONS
- Python 3.11 / SQLAlchemy 2.0.52: `pyhive[presto]==0.6.5` + engine
construction fails `ModuleNotFoundError: sqlalchemy.databases`;
`pyhive[presto]==0.7.0` passes construction and compiles `SELECT :value` as
`SELECT %(value)s` without network I/O.
- `pytest -q tests/unit_tests/db_engine_specs/test_presto.py`: **135
passed**, independently rerun. Baseline: 134 passed.
- Staged `pre-commit run`: all applicable hooks passed, including mypy,
Ruff, pylint, and engine metadata validation.
- Independent review: no actionable findings; independently repeated
exact-version negative/positive probes.
The regression checks the **installed** dialect. The paired version probes
establish floor causality; changing TOML alone does not change an already
installed driver. No live Presto, TLS, reflection, or production-image
qualification claimed. Existing Presto CI owns service testing.
### ADDITIONAL INFORMATION
- [x] Has associated issue:
[SC-120252](https://app.shortcut.com/preset/story/120252)
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
