aminghadersohi commented on PR #44285: URL: https://github.com/apache/superset/pull/44285#issuecomment-5689528796
## CI is green — the earlier red was the upstream dual-head condition, now resolved Superseding my previous comment, which reported 15 failing jobs. That blocker is gone: #44288 landed as `4c27cbd007`, and master now resolves to the single head `e2f3a1b9c640` (merging `c7f53d184ea2` and `88a01c781622`). This branch is rebased onto `4c27cbd007`; head is `478d7eb4d0242d15e03bfe269c3695f1ad583813`. The five-file diff is unchanged and the branch still touches zero migrations. ### Verdict at the current head: all applicable checks terminal green - Check runs: **85 success, 10 skipped, 2 neutral — 0 failure, 0 pending** - Combined commit status: success - Workflow runs at the SHA: 25 total, 22 success + 3 skipped — **no failed, cancelled, action-required, or timed-out runs, including zero-job ones** (queried the runs API separately so a zero-job workflow failure could not hide behind the check-run rollup) All 15 jobs that previously failed now pass, including the two most specific to this change — **`test-postgres-presto`** and **`test-postgres-hive`** — alongside `Enforce single Alembic migration head`, `test-sqlite`, `test-mysql`, `test-postgres (current)`, `test-load-examples`, `cypress-matrix`, all four `playwright-tests*` matrices, and all three `docker-build` variants. Nothing was waived or retried into green. The 10 skipped contexts are frontend/bot/master-push-only jobs excluded by the Python-and-docs path filter; the 2 neutral are informational Netlify reports. Neither is a test gate for this change. The branch is 4 commits behind master but `MERGEABLE` with no conflicts, and `mergeStateStatus` is `BLOCKED` (review required) rather than `BEHIND`, so I have deliberately not rebased again — that would discard a verified-green run for no benefit. Happy to freshen it if a maintainer prefers. ### Change verification on this exact tree - `tests/unit_tests/db_engine_specs/test_presto.py`: **135 passed** - Scoped `pre-commit` across all five changed files: all applicable hooks pass (mypy, Ruff, pylint, engine-spec metadata validation) - `version_requirements` in `docs/src/data/databases.json` matches `PrestoEngineSpec` byte-for-byte, with field ordering consistent with the generator's convention (cf. the existing Firebird entry) - Floor causality reproduced in a clean Python 3.11 venv: SQLAlchemy 2.0.52 with `pyhive[presto]==0.6.5` fails with `ModuleNotFoundError: No module named 'sqlalchemy.databases'`; with `==0.7.0` the dialect loads as `PrestoDialect` and compiles `SELECT :value` to `SELECT %(value)s` with no socket use ### Review status No submitted reviews and no inline threads. The automated reviewer's latest run reports 0 actionable suggestions. The only remaining gate is maintainer approval and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
