sadpandajoe commented on code in PR #44208:
URL: https://github.com/apache/superset/pull/44208#discussion_r4013906325
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/utils.tsx:
##########
@@ -84,19 +81,22 @@ function getSortingInfo<T extends object>(
}
export function mapColumns<T extends object>(
- columns: EnhancedColumnInstance<T>[],
- headerGroups: EnhancedHeaderGroup<T>[],
+ columns: ListViewColumn<T>[],
+ headerGroups: HeaderGroup<T>[],
columnsForWrapText?: string[],
) {
return columns.map(column => {
- const { isSorted, isSortedDesc } = getSortingInfo(headerGroups, column.id);
+ const id = column.id ?? '';
Review Comment:
Id-less columns now all receive the same non-null Ant Design sorter key
(`''`). On Action Log, all eight columns omit `id`, so clicking one header
marks every header sorted (including `aria-sort`) and carries the direction
cycle across columns; can we preserve `undefined` for `key`/`dataIndex` and use
a separate fallback only for the string lookups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
