rusackas commented on code in PR #44208:
URL: https://github.com/apache/superset/pull/44208#discussion_r4021357833
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/utils.tsx:
##########
@@ -84,19 +81,22 @@ function getSortingInfo<T extends object>(
}
export function mapColumns<T extends object>(
- columns: EnhancedColumnInstance<T>[],
- headerGroups: EnhancedHeaderGroup<T>[],
+ columns: ListViewColumn<T>[],
+ headerGroups: HeaderGroup<T>[],
columnsForWrapText?: string[],
) {
return columns.map(column => {
- const { isSorted, isSortedDesc } = getSortingInfo(headerGroups, column.id);
+ const id = column.id ?? '';
Review Comment:
Good catch, fixed — key/dataIndex now pass `column.id` through as-is
(undefined stays undefined), the `''` fallback is only used for the sort lookup
and ellipsis check now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
