kokhlo commented on issue #44314: URL: https://github.com/apache/superset/issues/44314#issuecomment-5683668611
Confirming the RCA on current master: `superset-frontend/src/explore/components/ControlPanelsContainer.test.tsx` line 142 is the file's only `userEvent` call and it is still un-awaited. After #43512 every user-event API returns a promise and dispatches pointer events across `delay: 0` yields inside RTL's `asyncWrapper`, so an un-awaited `click` runs its dispatch inside `waitFor`'s 1000 ms budget — exactly the "4 headers, Customize never rendered" shape in the CI runs above. `#43512` updated 114 files for the v14 API but missed this one (last touched in #40229). Plan: add the missing `await` on line 142, matching the convention the rest of the suite already uses after #43512 and the precedent fixes #35918 / #35993. One-line diff, no behavior change beyond letting the click finish before the assertion starts polling. PR within the hour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
